DefaultStackSynthesizer: Using a StackSynthesizer and Sharing Assets will only Publish One Asset and Not the Other

[ObOne5524]

Describe the bug

If a Synthesizer is used and the an Asset is shared between two Stacks on the same App, one of the Stacks will have a published asset to reference while the other Stack will not.

Expected Behavior

If a Synthesizer is used and the prefixes are different, the Assets should be able accessible to both Stacks.

Current Behavior

One Stack will be able to access the asset, while the other will return a Resource handler returned message: "Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist. due to a missing asset.

Reproduction Steps

1. Define a bin or app.py file that creates two stacks
2. Define a DefaultStackSynthesizer
3. Define a Lambda Function resource with a logRetention prop

Possible Solution

Since this is unique to version 2.8X.X, the Asset removal might need to be reviewed

Additional Information/Context

No response

CDK CLI Version

2.81.0

Framework Version

No response

Node.js Version

18.16.0

OS

macOS 12.6.6

Language

Typescript, Python, .NET, Java, Go

Language Version

5.0.4

Other information

No response

[pahud]

Thank you. Are you able to provide a minimal code sample that I can copy/paste to reproduce this bug?

[ObOne5524]

Bin File:

#!/usr/bin/env node
import * as cdk from 'aws-cdk-lib';
import { SharedAssetStack } from '../lib/shared_asset-stack';
import { SharedAssetStack2 } from '../lib/shared_asset-stack2';

const app = new cdk.App();

const stack1Synth = new cdk.DefaultStackSynthesizer({
    bucketPrefix: "newtest/"
})

const stack2Synth = new cdk.DefaultStackSynthesizer({
    bucketPrefix: "newtest2/"
})

new SharedAssetStack(app, 'SharedAssetStack', {synthesizer: stack1Synth});
new SharedAssetStack2(app, 'SharedAssetStack2', {synthesizer: stack2Synth});

Lib File:
Stack 1:

import { Duration, Stack, StackProps } from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as lambda from 'aws-cdk-lib/aws-lambda'
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import * as logs from 'aws-cdk-lib/aws-logs'
import { Construct } from 'constructs';
import * as path from 'path';

export class SharedAssetStack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    new lambda.Function(this, 'Function', {
        runtime: lambda.Runtime.NODEJS_18_X,
        handler: 'index.handler',
        code: lambda.Code.fromAsset(path.join(__dirname, 'lambda-handler')),
        logRetention: logs.RetentionDays.ONE_WEEK
      });
    }
}

Stack 2:

import { Duration, Stack, StackProps } from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as lambda from 'aws-cdk-lib/aws-lambda'
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import * as logs from 'aws-cdk-lib/aws-logs'
import { Construct } from 'constructs';
import * as path from 'path';

export class SharedAssetStack2 extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    new lambda.Function(this, 'Function', {
        runtime: lambda.Runtime.NODEJS_18_X,
        handler: 'index.handler',
        code: lambda.Code.fromAsset(path.join(__dirname, 'lambda-handler')),
        logRetention: logs.RetentionDays.ONE_WEEK
      });
    }
}

Index Handler:

import { Context, APIGatewayProxyCallback, APIGatewayEvent } from 'aws-lambda';

export const handler = (event: APIGatewayEvent, context: Context, callback: APIGatewayProxyCallback): void => {
    console.log(`Event: ${JSON.stringify(event, null, 2)}`);
    console.log(`Context: ${JSON.stringify(context, null, 2)}`);
    callback(null, {
        statusCode: 200,
        body: JSON.stringify({
            message: 'hello world!',
        }),
    });
};

[ObOne5524]

If you run cdk deploy --all the Resource handler returned message: "Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist. will be returned by one of the Stacks

[rix0rrr]

Thanks for the report!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.