-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new "Runtime" parameter is required for deploying Ray Glue Jobs #25787
Comments
@jvmunhoz reproduction code would be helpful, but I'm not sure how the runtime property is supposed to be defined through CloudFormation or even the API in the first place. After looking into it a bit, this looks to me like it might be a bug with the service. I cannot see any options in the CloudFormation Job resource that would help with this. And, I cannot even see the Runtime prop on the DataType where it is supposed to be |
Just posted a snippet for creating a ray job. Just |
It looks like it was just added to CloudFormation documentation https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-job-jobcommand.html |
You can use escape hatches to fill in the necessary runtime like so until we find a solution for this: job = Glue.job(self, ...)
cfn_job = job.node.default_child
cfn_job.add_property_override('Command.Runtime', runtime) I can't find anywhere in the docs what the accepted runtime values are, all I can find is the regex. We might need more time for docs to come in until we're able to properly implement this |
Any updates on the PR? |
By the way, the value of runtime in above workaround should be Ray2.4 From api reference - https://docs.aws.amazon.com/glue/latest/dg/ray-jobs-section.html |
AWS Glue recently changed API and CloudFormation spec to require `Runtime` parameter for Ray jobs. To address the changes, I am submitting this PR. This PR is for fixing the issue #25787. ## Reference CloudFormation doc has been also updated for `Runtime` parameter. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-job-jobcommand.html#cfn-glue-job-jobcommand-runtime ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The PR has been merged. |
thanks |
|
Describe the bug
When trying to deploy Ray Glue Jobs through CDK, they will fail because it is now required to provide the "Runtime" parameter, which, as far as I know, is currently not mapped (as of 2.81.0).
Expected Behavior
We should be able to set the "Runtime" parameter on Ray Glue Jobs so they can be properly deployed.
Current Behavior
Reproduction Steps
Trying to deploy any kind of Ray Glue Job will do.
Just
cdk init
in an empty folder, paste the entire code inside the app.py file created, create ahello_world.py
file inside the root folder andcdk deploy
Possible Solution
Map the new "Runtime" parameter to the python executable props for Ray Jobs
Additional Information/Context
It was apparently a very recent change, since yesterday everything was fine.
CDK CLI Version
2.81.0
Framework Version
No response
Node.js Version
8.1.0
OS
Amazon Linux 2
Language
Python
Language Version
Python 3.9.14
Other information
No response
The text was updated successfully, but these errors were encountered: