aws-batch-alpha: EcsJobDefinition.jobDefinitionName returns the ARN

[gael-ft]

Describe the bug

In EcsJobDefinition, looks like at the end of the constructor you override the field "jobDefinitionName" with the CfnJobDefinition ref.
Meaning if we try to access it later, we'll get a different value of what it has been created with.

Expected Behavior

EcsJobDefinition.jobDefinitionName to return the CfnJobDefinition.jobDefinitionName and not the ARN of the resource

Current Behavior

EcsJobDefinition.jobDefinitionNam returns the ARN (+ revision)

Reproduction Steps

const jobDef = new EcsJobDefinition(this, 'Resource', {
  // ...
  jobDefinitionName: 'toto'
  //...
});

jobDef.jobDefinitionName; // a Token which resolves to arn:aws:...:job-definition:toto:1

Possible Solution

Just remove this.jobDefinitionName = this.getResourceNameAttribute(resource.ref);

github link

Additional Information/Context

No response

CDK CLI Version

2.74.0 (build 70e2a33)

Framework Version

No response

Node.js Version

v16.13.0

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response

[peterwoodworth]

Similar to #25093, ref returns the arn instead of the name. Here's the actual fix in the linked PR for the similar issue:

this.jobQueueName = Stack.of(this).splitArn(this.jobQueueArn, ArnFormat.SLASH_RESOURCE_NAME).resourceName!;

We'll want to do the exact same thing, given this is the same exact bug just on a different construct. We don't want to remove this altogether because then customers who don't specify the name cannot reference it. Thanks for reporting!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.