Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkglint: make sure an .npmignore file exists #217

Closed
eladb opened this issue Jul 2, 2018 · 0 comments
Closed

pkglint: make sure an .npmignore file exists #217

eladb opened this issue Jul 2, 2018 · 0 comments

Comments

@eladb
Copy link
Contributor

eladb commented Jul 2, 2018

If .npmignore doesn't exist, .gitignore is used, which is usually not what we want. For example, .gitignore in typescript projects will likely exclude *.js files from git, but these are required when we pack the module!
eladb pushed a commit that referenced this issue Jul 2, 2018
Missing .npmignore in @aws-cdk/cloudwatch
67be3c5 
This caused a runtime error of `Cannot find module './alarm'`
only to be discovered post-installation of the bundle, which is
extremely late in the game.

Related to #217
@eladb eladb mentioned this issue Jul 2, 2018
Merged
eladb pushed a commit that referenced this issue Jul 2, 2018
Missing .npmignore in @aws-cdk/cloudwatch (#218)
1fd4edc 
This caused a runtime error of `Cannot find module './alarm'`
only to be discovered post-installation of the bundle, which is
extremely late in the game.

Related to #217
@rix0rrr rix0rrr closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @eladb