Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(glue): broken links #20546

Closed
girotomas opened this issue May 30, 2022 · 2 comments · Fixed by #20577
Closed

(glue): broken links #20546

girotomas opened this issue May 30, 2022 · 2 comments · Fixed by #20577
Labels
@aws-cdk/aws-glue Related to AWS Glue documentation This is a problem with documentation. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@girotomas
Copy link

Describe the issue

In the cdk docs (this page: https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-glue-alpha.SerializationLibrary.html ) this link is broken https://hive.apache.org/javadocs/r1.2.2/api/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.html (also for v1)

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-glue-alpha.SerializationLibrary.html this link is broken https://hive.apache.org/javadocs/r1.2.2/api/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.html
@girotomas girotomas added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels May 30, 2022
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label May 30, 2022
@kaizencc
Copy link
Contributor

Looks like all the links starting https://hive.apache.org/javadocs are broken. Should be updated to something like this:

https://svn.apache.org/repos/infra/websites/production/hive/content/javadocs/r3.1.3/api/index.html

Doesn't look like there are links to individual components anymore, so we should just update them all to the same link.

@kaizencc kaizencc added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 31, 2022
@kaizencc kaizencc removed their assignment May 31, 2022
@kaizencc kaizencc changed the title glue: broken link (glue): broken links May 31, 2022
@kaizencc kaizencc added the good first issue Related to contributions. See CONTRIBUTING.md label May 31, 2022
@daschaa daschaa mentioned this issue Jun 1, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #20577 Jun 2, 2022
mergify bot pushed a commit that referenced this issue Jun 2, 2022
@daschaa
docs(glue): refresh links for aws glue documentation (#20577)
b9065a5 
Fixes #20546

Refreshes the links in the AWS Glue docs pointing to the Apache Hive website (for more information see the issue #20546 )

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

daschaa added a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
@daschaa
docs(glue): refresh links for aws glue documentation (aws#20577)
eb6d6b0 
Fixes aws#20546

Refreshes the links in the AWS Glue docs pointing to the Apache Hive website (for more information see the issue aws#20546 )

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-glue Related to AWS Glue documentation This is a problem with documentation. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(glue): refresh links for aws glue documentation daschaa/aws-cdk
2 participants
@girotomas @kaizencc