(aws-logs): Missing supported log retention periods #20346
Labels
@aws-cdk/aws-logs
Related to Amazon CloudWatch Logs
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
bcelenza
added
bug
bcelenza
added a commit
to bcelenza/aws-cdk
that referenced
this issue
May 14, 2022
4 tasks
kaizencc
added
p2
effort/small
mergify bot
pushed a commit
that referenced
this issue
May 16, 2022
Adds newly supported log retention periods per [the docs](https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutRetentionPolicy.html#API_PutRetentionPolicy_RequestSyntax). Resolves #20346 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this issue
May 23, 2022
Adds newly supported log retention periods per [the docs](https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutRetentionPolicy.html#API_PutRetentionPolicy_RequestSyntax). Resolves aws#20346 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The current list of log retention periods is missing new options allowed by CloudWatch logs per their documents: 2192, 2557, 2922, and 3288 days.
Expected Behavior
A developer working with the CDK would expect all available options to be present.
Current Behavior
The CDK is limited to a subset of the available options.
Reproduction Steps
N/A
Possible Solution
Add the options. :)
Additional Information/Context
No response
CDK CLI Version
2.23.0
Framework Version
No response
Node.js Version
16.14.0
OS
Mac OS
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: