Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(s3-deployment): BucketDeployment ephemeral storage for internal lambda #19947

Closed
2 tasks
krisztianpinter opened this issue Apr 17, 2022 · 1 comment · Fixed by #19958
Closed
2 tasks

(s3-deployment): BucketDeployment ephemeral storage for internal lambda #19947

krisztianpinter opened this issue Apr 17, 2022 · 1 comment · Fixed by #19958
Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@krisztianpinter
Copy link

Describe the feature

Lambda now has ephemeral storage size, which was added #19605. However, BucketDeployment creates a lambda function internally, and this setting is missing from there.

Use Case

Uploading big files is only possible via EFS volumes and VPC setup, as it hits ephemeral disk limit. Now we don't have to deal with this limitation anymore.

Proposed Solution

Add the parameter to BucketDeployment constructor, as was added to the lambda Function constructor, and similarly how memory size is present in the BucketDeyployment constructor already.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.20.0 (build 738ef49)

Environment details (OS name and version, etc.)

Linux Mint 19
@krisztianpinter krisztianpinter added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2022
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Apr 17, 2022
@kaizencc kaizencc added p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 18, 2022
@kaizencc kaizencc removed their assignment Apr 18, 2022
@kaizencc kaizencc mentioned this issue Apr 18, 2022
Merged
4 tasks
@kaizencc kaizencc changed the title BucketDeployment ephemeral storage for internal lambda (s3-deployment): BucketDeployment ephemeral storage for internal lambda Apr 18, 2022
@mergify mergify bot closed this as completed in #19958 Apr 20, 2022
mergify bot pushed a commit that referenced this issue Apr 20, 2022
@kaizencc
feat(s3-deployment): ephemeral storage size property for bucket deplo…
3ce40b4 
…yment (#19958)

Closes #19947.

Followed the same convention for `memoryLimit` property so that a new singleton lambda configuration will be created when bucket deployments are specified with different `ephemeralStorageSize` configurations.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@kaizencc
feat(s3-deployment): ephemeral storage size property for bucket deplo…
f1ada62 
…yment (aws#19958)

Closes aws#19947.

Followed the same convention for `memoryLimit` property so that a new singleton lambda configuration will be created when bucket deployments are specified with different `ephemeralStorageSize` configurations.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(s3-deployment): ephemeral storage size property for bucket deployment aws/aws-cdk
2 participants
@krisztianpinter @kaizencc