Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(redshift): specify classic or elastic resize #19430

Closed
1 of 2 tasks
Baisang opened this issue Mar 17, 2022 · 2 comments · Fixed by #21084
Closed
1 of 2 tasks

(redshift): specify classic or elastic resize #19430

Baisang opened this issue Mar 17, 2022 · 2 comments · Fixed by #21084
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@Baisang
Copy link

Baisang commented Mar 17, 2022

Description

I want to be able to specify this CFN parameter in CDK: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-redshift-cluster.html#cfn-redshift-cluster-classic

Use Case

This will let users control whether to resize using Classic or Elastic resize for their cluster.

Proposed Solution

From my understanding this is just adding another parameter to the generated CFN, so hopefully it would be simple?

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Baisang Baisang added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2022
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Mar 17, 2022
@skinny85
Copy link
Contributor

skinny85 commented May 4, 2022

Thanks for opening the issue @Baisang! This should be a relatively simple change, adding a new property to the ClusterProps interface, and then using it somewhere here.

Thanks,
Adam

@skinny85 skinny85 added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs and removed needs-triage This issue or PR still needs to be triaged. labels May 4, 2022
@skinny85 skinny85 removed their assignment May 4, 2022
@daschaa daschaa mentioned this issue Jul 10, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21084 Jul 12, 2022
mergify bot pushed a commit that referenced this issue Jul 12, 2022
@daschaa
feat(redshift): adds classic or elastic resize type option (#21084)
b5e9c1a 
Fixes #19430.

Adds the property `classicResizing` property to the `ClusterProps`. If not set or set to false, elastic resizing is used.

I feel like an entry in the README is not necessary. If it is ok, please add `pr-linter/exempt-readme` label to this PR.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(redshift): adds classic or elastic resize type option daschaa/aws-cdk
2 participants
@skinny85 @Baisang