Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Readme sample code out of date (cluster.addDefaultAutoScalingGroupCapacity) #1926

Closed
fulghum opened this issue Mar 2, 2019 · 1 comment · Fixed by #2051
Closed

ECS Readme sample code out of date (cluster.addDefaultAutoScalingGroupCapacity) #1926

fulghum opened this issue Mar 2, 2019 · 1 comment · Fixed by #2051
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.

Comments

@fulghum
Copy link
Contributor

fulghum commented Mar 2, 2019

When cluster.addDefaultAutoScalingGroupCapacity was renamed to addCapacity, sample code references were missed.

ECS README:
https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-ecs/README.md

cdk-examples should be checked, too. ex:
https://github.com/aws-samples/aws-cdk-examples/blob/master/typescript/ecs/ecs-load-balanced-service/index.ts#L16
@fulghum fulghum added documentation @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Mar 2, 2019
@sam-goodwin sam-goodwin added the bug This issue is a bug. label Mar 4, 2019
@SoManyHs SoManyHs mentioned this issue Mar 5, 2019
Closed
@JoHuang
Copy link

JoHuang commented Mar 19, 2019

Hi

After changing to addCapacity function, there is no instanceCount option to pass into.
How should I set instanceCount?

Thanks

rix0rrr added a commit that referenced this issue Mar 19, 2019
@rix0rrr
chore: update desiredCapacity in README
2fd93db 
Update `instanceCount` => `desiredCapacity` in ECS README.

Fixes #1926.
@rix0rrr rix0rrr mentioned this issue Mar 19, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Mar 19, 2019
@rix0rrr
chore: update desiredCapacity in README (#2051)
4941ad2 
Update `instanceCount` => `desiredCapacity` in ECS README.

Fixes #1926.
rix0rrr added a commit to alex-berger/aws-cdk that referenced this issue Mar 19, 2019
@rix0rrr
chore: update desiredCapacity in README (aws#2051)
c795ca2 
Update `instanceCount` => `desiredCapacity` in ECS README.

Fixes aws#1926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update desiredCapacity in README aws/aws-cdk
3 participants
@fulghum @JoHuang @sam-goodwin