-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msk: add bootstrapBrokersSaslIam #18355
Comments
Hi @otaviomacedo , Thanks. |
I just ran today:
|
When accessing the bootstrap brokers of a cluster configured with property `clientAuthentication: msk.ClientAuthentication.sasl({ iam: true })` One can access the bootstrap brokers from the command line: `aws kafka get-bootstrap-brokers --cluster-arn <ClusterArn>` This will return an object: ``` { "BootstrapBrokerStringSaslIam": "..." } ``` This PR adds the ability to access the bootstrap brokers directly as a property of the Kafka cluster. This can now be done via the `cluster.bootstrapBrokersSaslIam` property. Fixes #18355 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
When accessing the bootstrap brokers of a cluster configured with property `clientAuthentication: msk.ClientAuthentication.sasl({ iam: true })` One can access the bootstrap brokers from the command line: `aws kafka get-bootstrap-brokers --cluster-arn <ClusterArn>` This will return an object: ``` { "BootstrapBrokerStringSaslIam": "..." } ``` This PR adds the ability to access the bootstrap brokers directly as a property of the Kafka cluster. This can now be done via the `cluster.bootstrapBrokersSaslIam` property. Fixes aws#18355 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Description
Currently @aws-cdk/aws-msk-alpha package supports:
bootstrapBrokers
bootstrapBrokersTls
bootstrapBrokersSaslScram
Please add support for a new property
bootstrapBrokersSaslIAM
Use Case
In the case where the Kafka cluster is configured using Sasl with IAM, e.g.:
It is currently not possible to access the bootstrap brokers directly as a property of the Kafka cluster.
Proposed Solution
The
Cluster
class ofaws-msk-alpha
contains a private method_bootstrapBrokers
. The other public bootstrapBroker* functions are defined in relation to this function:A similar function can be defined for SaslIam:
Other information
When accessing the bootstrap brokers of a cluster configured with property
One can access the bootstrap brokers from the command line:
This will return an object:
Acknowledge
The text was updated successfully, but these errors were encountered: