feat(iot): add Action to put records to a Firehose stream #17466
Conversation
|
|
There was a problem hiding this comment.
Looks great @yamatatsu! A few tiny nitpicky comments, mainly around docs.
packages/@aws-cdk/aws-iot-actions/lib/firehose-stream-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/firehose-stream-action.ts
Outdated
Show resolved
Hide resolved
| @@ -79,6 +80,7 @@ | |||
| "jest": "^27.3.1" | |||
| }, | |||
| "dependencies": { | |||
| "@aws-cdk/aws-kinesisfirehose": "0.0.0", | |||
There was a problem hiding this comment.
Can we keep these in alphabetical order please?
| @@ -90,6 +92,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/aws/aws-cdk", | |||
| "peerDependencies": { | |||
| "@aws-cdk/aws-kinesisfirehose": "0.0.0", | |||
There was a problem hiding this comment.
Same here (alphabetical order).
Co-authored-by: Adam Ruka <[email protected]>
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
Co-authored-by: Adam Ruka <[email protected]>
|
addressed! 😃 |
skinny85
changed the title
| /** | ||
| * Configuration properties of an action for the Kinesis Data Firehose stream. | ||
| */ | ||
| export interface FirehoseStreamProps extends CommonActionProps { |
There was a problem hiding this comment.
Missed this:
| export interface FirehoseStreamProps extends CommonActionProps { | |
| export interface FirehoseStreamActionProps extends CommonActionProps { |
| const bucket = new s3.Bucket(this, 'MyBucket', { | ||
| removalPolicy: cdk.RemovalPolicy.DESTROY, | ||
| }); |
There was a problem hiding this comment.
Let's kill the removalPolicy in the example, it doesn't add much:
| const bucket = new s3.Bucket(this, 'MyBucket', { | |
| removalPolicy: cdk.RemovalPolicy.DESTROY, | |
| }); | |
| const bucket = new s3.Bucket(this, 'MyBucket'); |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hey @yamatatsu, I accidentally approved the PR, when I wanted to "Request changes" 😜. Because of that, I submitted a PR with the fixes I asked for: #17495. |
…17495) An action item from #17466 (review). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ws#17495) An action item from aws#17466 (review). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I'm trying to implement aws-iot L2 Constructs. This PR is one of steps after following PR: - aws#16681 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ws#17495) An action item from aws#17466 (review). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I'm trying to implement aws-iot L2 Constructs.
This PR is one of steps after following PR:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license