Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iot): rename FirehoseStreamProps to FirehoseStreamActionProps #17495

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

skinny85
Copy link
Contributor

An action item from #17466 (review).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 self-assigned this Nov 12, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 12, 2021

@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Nov 12, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 12, 2021
@yamatatsu
Copy link
Contributor

Sorry that my oversight, and thanks for your fixing! 😀

@skinny85
Copy link
Contributor Author

Sorry that my oversight, and thanks for your fixing! 😀

Nah, this is strictly my fault. You're doing great work 👍.

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c9b0378
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4cd4af8 into aws:master Nov 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the chore/rename-iot-firehose-action-props branch November 15, 2021 21:07
mpvosseller pushed a commit to mpvosseller/aws-cdk that referenced this pull request Nov 16, 2021
…ws#17495)

An action item from aws#17466 (review).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ws#17495)

An action item from aws#17466 (review).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iot Related to AWS IoT contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants