Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rds): set allocatedStorage with DatabaseInstanceReadReplica #17083

Closed
1 of 2 tasks
peterwoodworth opened this issue Oct 20, 2021 · 2 comments · Fixed by #28789
Closed
1 of 2 tasks

(rds): set allocatedStorage with DatabaseInstanceReadReplica #17083

peterwoodworth opened this issue Oct 20, 2021 · 2 comments · Fixed by #28789
Assignees
@aaythapa
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@peterwoodworth
Copy link
Contributor

peterwoodworth commented Oct 20, 2021 •
edited
Loading

Description

When setting iops on a DatabaseInstanceReadReplica, there should be an easy way to also set allocatedStorage so that we can avoid CloudFormation deploy-time error

You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.

Currently the only way to set storage size is with escape hatches

Use Case

See #16934 for full details

Proposed Solution

CDK should feature a synth-time check for both values in addition to supporting the allocatedStorage prop with either an error message or warning. The deploy time necessary to debug this issue is frustratingly long

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@peterwoodworth peterwoodworth added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Oct 20, 2021
@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort p1 @aws-cdk/aws-rds Related to Amazon Relational Database and removed @aws-cdk/aws-rds Related to Amazon Relational Database needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2021
@peterwoodworth peterwoodworth mentioned this issue Oct 20, 2021
Closed
@skinny85 skinny85 added the feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs label Oct 20, 2021
@skinny85 skinny85 removed their assignment Oct 20, 2021
@npvisual
Copy link

npvisual commented Apr 6, 2022 •
edited
Loading

Seeing the same issue as described in #16934. Also validated the suggested fix (in python however) and was able to deploy the replica without that error message.

@comcalvi comcalvi added p2 and removed p1 labels Jan 27, 2023
@peterwoodworth peterwoodworth added the good first issue Related to contributions. See CONTRIBUTING.md label Aug 18, 2023
@peterwoodworth peterwoodworth mentioned this issue Aug 18, 2023
Closed
@aaythapa aaythapa self-assigned this Jan 17, 2024
@aaythapa aaythapa mentioned this issue Jan 20, 2024
Merged
@mergify mergify bot closed this as completed in #28789 Jan 24, 2024
mergify bot pushed a commit that referenced this issue Jan 24, 2024
@aaythapa
feat(rds): allocatedStorage parameter for DatabaseInstanceReadReplica (…
df8fbc4 
…#28789)

Adding an optional `allocatedStorage` parameter to DatabaseInstanceReadReplica. Allows customers to set the [AllocatedStorage](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbinstance.html#cfn-rds-dbinstance-allocatedstorage) for their replica instance. 

Note: Didn't add any synth checks as the original deployment issue outlined in #17083 seems to be fixed (Deployed the failed template and the replica instance will automatically inherit the storage of the source instance). Customers should still be able to set `allocatedStorage`.

Closes #17083.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaythapa aaythapa

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): allocatedStorage parameter for DatabaseInstanceReadReplica aaythapa/aws-cdk
5 participants
@skinny85 @npvisual @peterwoodworth @comcalvi @aaythapa