Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message "null" when trying to read the parameter from SSM when it doesn't exist #1621

Closed
farminf opened this issue Jan 28, 2019 · 1 comment · Fixed by #1630
Closed

Error message "null" when trying to read the parameter from SSM when it doesn't exist #1621

farminf opened this issue Jan 28, 2019 · 1 comment · Fixed by #1630
Labels
bug This issue is a bug.

Comments

@farminf
Copy link

farminf commented Jan 28, 2019

When the SSM parameter doesn't exist and want to get it by SSMParameterProvider, the error message is just "null". it needs to have better message with the reason and parameter name.
@RomainMuller RomainMuller added the bug This issue is a bug. label Jan 29, 2019
RomainMuller added a commit that referenced this issue Jan 29, 2019
@RomainMuller
fix: Improve error message in SSMParameterProvider
1c1c0c2 
When using a non-existent SSM Parameter with the SSMParameterProvider,
the error message `null` was returned by the toolkit instead of a more
meaningful error mentioning important details such as the parameter name
that was looked up and the account/region where it could not be found.

Fixes #1621
@RomainMuller RomainMuller mentioned this issue Jan 29, 2019
Merged
@RomainMuller
Copy link
Contributor

The code clearly had intention to return a friendly error message, but failed to account for the particular code path that happens when the parameter does not exist in the account/region at all. I'm fixing this...

RomainMuller added a commit that referenced this issue Jan 29, 2019
@RomainMuller
fix: Improve error message in SSMParameterProvider (#1630)
6a8e010 
When using a non-existent SSM Parameter with the SSMParameterProvider,
the error message `null` was returned by the toolkit instead of a more
meaningful error mentioning important details such as the parameter name
that was looked up and the account/region where it could not be found.

Fixes #1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Improve error message in SSMParameterProvider aws/aws-cdk
2 participants
@RomainMuller @farminf