Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-chatbot): Add notification topics to an existing SlackChannelConfiguration construct #15588

Closed
gshpychka opened this issue Jul 15, 2021 · 2 comments · Fixed by #16643
Closed
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@gshpychka
Copy link
Contributor

gshpychka commented Jul 15, 2021

I'm looking for the ability to add SNS notificaiton topics to a SlackChannelConfiguration object outside of its constructor.

Use Case

Define a channel configuration in one stack and add some SNS topics to it in another

Proposed Solution

This would probably be a addNotificationTopics class method.

This is a 🚀 Feature Request

@gshpychka gshpychka added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 15, 2021
@github-actions github-actions bot added the @aws-cdk/aws-chatbot Related to AWS Chatbot label Jul 15, 2021
@BenChaimberg
Copy link
Contributor

Sure thing; just need to add a private property to SlackChannelConfiguration for notificationTopics and use Lazy.list for the insertion into the L1

snsTopicArns: props.notificationTopics?.map(topic => topic.topicArn),

I am unassigning myself and marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to reevaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Please feel free to work on this issue yourself and request my review if you submit a PR or would like design help! See CONTRIBUTING.md for guidelines.

@BenChaimberg BenChaimberg added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 16, 2021
@BenChaimberg BenChaimberg removed their assignment Jul 16, 2021
@mergify mergify bot closed this as completed in #16643 Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants