Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-appsync): Bad error message - Missing default OIDC Configuration #15039

Closed
Matt-Butler opened this issue Jun 8, 2021 · 4 comments · Fixed by #15830
Closed

(aws-appsync): Bad error message - Missing default OIDC Configuration #15039

Matt-Butler opened this issue Jun 8, 2021 · 4 comments · Fixed by #15830
Assignees
@peterwoodworth
Labels
@aws-cdk/aws-appsync Related to AWS AppSync bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@Matt-Butler
Copy link

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-appsync/lib/graphqlapi.ts#L498

if (mode.authorizationType === AuthorizationType.USER_POOL && !mode.userPoolConfig) {
throw new Error('Missing default OIDC Configuration');
}

throw new Error('Missing userPoolConfig');
@Matt-Butler Matt-Butler added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jun 8, 2021
@Matt-Butler Matt-Butler changed the title Bad error message Bad error message - Missing default OIDC Configuration Jun 8, 2021
@peterwoodworth peterwoodworth self-assigned this Jun 8, 2021
@peterwoodworth
Copy link
Contributor

Hey @Matt-Butler, can you more clearly state what the problem here is? Thanks.

@peterwoodworth peterwoodworth added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 8, 2021
@Matt-Butler
Copy link
Author

In this case, the user isn't missing the OIDC configuration. The user is missing userPoolConfig.

Expected:

Missing userPoolConfig

Actual:

Missing default OIDC Configuration

@peterwoodworth peterwoodworth changed the title Bad error message - Missing default OIDC Configuration (aws-appsync): Bad error message - Missing default OIDC Configuration Jun 9, 2021
@peterwoodworth peterwoodworth removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 9, 2021
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Jun 9, 2021
@peterwoodworth peterwoodworth added bug This issue is a bug. and removed guidance Question that needs advice or information. labels Jun 9, 2021
@peterwoodworth
Copy link
Contributor

Thank you for clarifying, is this something that you'd like to fix yourself? I'd be happy to take a look at the PR you make

@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort labels Jun 9, 2021
@peterwoodworth peterwoodworth mentioned this issue Jul 29, 2021
Merged
@mergify mergify bot closed this as completed in #15830 Jul 30, 2021
mergify bot pushed a commit that referenced this issue Jul 30, 2021
@peterwoodworth
fix(aws-appsync): graphqlapi throws incorrect error message for autho…
1f23313 
…rizationConfig (#15830)

fixes: #15039

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@peterwoodworth @TikiTDO
fix(aws-appsync): graphqlapi throws incorrect error message for autho…
4f48051 
…rizationConfig (aws#15830)

fixes: aws#15039

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@peterwoodworth @hollanddd
fix(aws-appsync): graphqlapi throws incorrect error message for autho…
5583dd8 
…rizationConfig (aws#15830)

fixes: aws#15039

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwoodworth peterwoodworth

Labels
@aws-cdk/aws-appsync Related to AWS AppSync bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-appsync): graphqlapi throws incorrect error message for authorizationConfig
3 participants
@otaviomacedo @Matt-Butler @peterwoodworth