Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(codepipeline): Pipeline to support fromCfnPipeline() #14795

Closed
2 tasks
0xjjoyy opened this issue May 20, 2021 · 1 comment
Closed
2 tasks

(codepipeline): Pipeline to support fromCfnPipeline() #14795

0xjjoyy opened this issue May 20, 2021 · 1 comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1

Comments

@0xjjoyy
Copy link

0xjjoyy commented May 20, 2021 •
edited
Loading

Ability to import a CodePipline as L2 Pipeline construct from existing CloudFormation template. Only from_pipeline_arn is supported.

Use Case

Ability to customize cfn resources existing in a template

Proposed Solution

Other

CloudFormation template
https://s3.amazonaws.com/solutions-reference/customizations-for-aws-control-tower/latest/custom-control-tower-initiation.template

CDK code

        template = cfn_inc.CfnInclude(self, "Template",
            template_file="../deployment/custom-control-tower-initiation.template")


        cfn_pipeline = template.get_resource("CustomControlTowerCodePipeline")
        pipeline = codepipeline.Pipeline.from_pipeline_arn(
            self,
            "CustomControlTowerCodePipelineL2",
            pipeline_arn=cfn_pipeline.ref,
        )
        pipeline.add_stage("sdfsd")

Stack

line 27, in __init__
    pipeline.add_stage("sdfsd")
 line 149, in __getattr__
    raise AttributeError(f"'%s' object has no attribute '%s'" % (type_info, name))
AttributeError: '<class 'aws_cdk.core.Resource'>+<class 'aws_cdk.aws_codepipeline._IPipelineProxy'>' object has no attribute 'add_stage'
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@0xjjoyy 0xjjoyy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 20, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label May 20, 2021
@skinny85 skinny85 added effort/large Large work item – several weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels May 20, 2021
This was referenced May 20, 2021
Open
Merged
mergify bot pushed a commit that referenced this issue Jun 3, 2021
@skinny85
feat(kms): introduce fromCfnKey() method (#14859)
1ff5b9e 
This is part 1 of adding support from converting L1 resources to L2 without making them immutable in the process.
Next phase after this will be adding support for `Bucket.fromCfnBucket()`
(which will use the method from KMS defined here).

Related issues: #9719 #14795 #14809

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@skinny85 skinny85 changed the title (codepipeline): Pipeline to support from_pipeline_name (codepipeline): Pipeline to support fromCfnPipeline() Jun 23, 2021
@skinny85 skinny85 removed their assignment Jun 24, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@skinny85 @hollanddd
feat(kms): introduce fromCfnKey() method (aws#14859)
a2fee5b 
This is part 1 of adding support from converting L1 resources to L2 without making them immutable in the process.
Next phase after this will be adding support for `Bucket.fromCfnBucket()`
(which will use the method from KMS defined here).

Related issues: aws#9719 aws#14795 aws#14809

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skinny85 @0xjjoyy