Toolkit: toolkit output domain name needs to use RegionalDomainName for GovCloud and CN compatibility

[rix0rrr]

Although { "Fn::GetAtt": "DomainName" } seems to work in CN, it does not work in GovCloud (in GovCloud the wrong domain name is returned).

RegionalDomainName seems to work; don't know if that will break something else.

[eladb]

@RomainMuller @rix0rrr what would you recommend we do to resolve this?

[rix0rrr]

Update the bootstrap template and test it in a couple of commercial regions.

[beary]

I just tried in cn-north-1, { "Fn::GetAtt": "DomainName" } reports an error.

After modified the DomainName to RegionalDomainName, the problem above was resolved.

aws-cdk/packages/aws-cdk/lib/api/bootstrap-environment.ts

Line 37 in 6d762f9

Value: { "Fn::GetAtt": ["StagingBucket", "DomainName"] }

[whimzyLive]

@rix0rrr @eladb This also doesn't work with CN regions.

[sassoo]

specifically govcloud customers are being negatively impacted by this. cdk deploy's do not work at all.