Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rds: cluster.addRotationSingleUser(); #13523

Closed
brentryan opened this issue Mar 10, 2021 · 1 comment · Fixed by #14677
Closed

aws-rds: cluster.addRotationSingleUser(); #13523

brentryan opened this issue Mar 10, 2021 · 1 comment · Fixed by #14677
Assignees
@skinny85
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@brentryan
Copy link
Contributor

Adding code like below to your cluster results in CDK generating the warning "Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customize rules, set allowAllOutbound=false on the SecurityGroup".

cluster.addRotationSingleUser();

What did you expect to happen?

No warning OR the underlying CDK methods should generate code that is compliant with itself to avoid unnecessary warnings.

What actually happened?

This warning shouldn't happen:

Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customize rules, set allowAllOutbound=false on the SecurityGroup

I believe this comes from this https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-rds/lib/cluster.ts#L539 which internally creates a new security group that triggers the warning.

Environment

  • CDK CLI Version : 1.91.0
  • Framework Version: 1.91.0
  • Node.js Version: 14.16.0
  • OS : Linux
  • Language (Version): TypeScript 4.2.2

This is 🐛 Bug Report
@brentryan brentryan added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 10, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Mar 10, 2021
jogold added a commit to jogold/aws-cdk that referenced this issue May 13, 2021
@jogold
chore(ec2): remove egress rule warning when using allowTo()/allowFrom()
cda6bc1 
No need to warn the user if the `addEgressRule()` call came from a
`allowTo()` or ` allowFrom()` call because he can't do anything about
it.

Closes aws#13523
@jogold jogold mentioned this issue May 13, 2021
Merged
@skinny85 skinny85 added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels May 18, 2021
@mergify mergify bot closed this as completed in #14677 Jun 4, 2021
mergify bot pushed a commit that referenced this issue Jun 4, 2021
@jogold
chore(ec2): remove egress rule warning when using allowFrom() (#14677)
c162b3e 
No need to warn the user if the `addEgressRule()` call came from a
`allowTo()` or ` allowFrom()` call because he can't do anything about
it.

Closes #13523


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@jogold @hollanddd
chore(ec2): remove egress rule warning when using allowFrom() (aws#14677
940e240 
)

No need to warn the user if the `addEgressRule()` call came from a
`allowTo()` or ` allowFrom()` call because he can't do anything about
it.

Closes aws#13523


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ec2): remove egress rule warning when using allowFrom() jogold/aws-cdk
2 participants
@skinny85 @brentryan