Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language binding version information to CDK::Metadata reporting #1258

Closed
eladb opened this issue Nov 28, 2018 · 0 comments · Fixed by #1288
Closed

Add language binding version information to CDK::Metadata reporting #1258

eladb opened this issue Nov 28, 2018 · 0 comments · Fixed by #1288
Assignees
@eladb
Labels
feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented Nov 28, 2018

No description provided.

@rix0rrr rix0rrr added the feature-request A feature should be added or improved. label Nov 29, 2018
@eladb eladb self-assigned this Dec 5, 2018
eladb pushed a commit that referenced this issue Dec 5, 2018
feat(core): include jsii runtime version in analytics
de20e38 
Add the jsii runtime version to the library version reporting
under "jsii-runtime". jsii runtime clients populate the JSII_AGENT
environment variable with this information (see aws/jsii#325).

If JSII_AGENT is not defined, we assume this is a node.js runtime
and include the node.js version.

Fixes #1258
eladb pushed a commit that referenced this issue Dec 5, 2018
feat(core): include jsii runtime version in analytics
6a49f77 
Add the jsii runtime version to the library version reporting
under "jsii-runtime". jsii runtime clients populate the JSII_AGENT
environment variable with this information (see aws/jsii#325).

If JSII_AGENT is not defined, we assume this is a node.js runtime
and include the node.js version.

Fixes #1258
@eladb eladb mentioned this issue Dec 5, 2018
Merged
9 tasks
eladb pushed a commit that referenced this issue Dec 5, 2018
feat(core): include jsii runtime version in analytics (#1288)
f06de18 
Add the jsii runtime version to the library version reporting
under "jsii-runtime". jsii runtime clients populate the JSII_AGENT
environment variable with this information (see aws/jsii#325).

If JSII_AGENT is not defined, we assume this is a node.js runtime
and include the node.js version.

Fixes #1258
Fixes awslabs/cdk-ops#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): include jsii runtime version in analytics aws/aws-cdk
2 participants
@rix0rrr @eladb