Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app-delivery]: Broken link to pipelines #10984

Closed
christophgysin opened this issue Oct 20, 2020 · 1 comment · Fixed by #10985
Closed

[app-delivery]: Broken link to pipelines #10984

christophgysin opened this issue Oct 20, 2020 · 1 comment · Fixed by #10985
Assignees
@skinny85
Labels
@aws-cdk/app-delivery Related to the app-delivery CI-CD package documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@christophgysin
Copy link
Contributor

The app-delivery README.md contains a broken link to the pipelines README.md:

https://docs.aws.amazon.com/cdk/api/latest/docs/app-delivery-readme.html

contains a link to:

https://docs.aws.amazon.com/cdk/api/latest/docs/pipelines.html

which doesn't exist and redirects to:

https://docs.aws.amazon.com/cdk/api/latest/docs/

because the correct link would be:

https://docs.aws.amazon.com/cdk/api/latest/docs/pipelines-readme.html

This is a 📕 documentation issue
@christophgysin christophgysin added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2020
@github-actions github-actions bot added the @aws-cdk/app-delivery Related to the app-delivery CI-CD package label Oct 20, 2020
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
fix(app-delivery): Fix URL to pipelines readme
b79980c 
fixes aws#10984
@christophgysin christophgysin mentioned this issue Oct 20, 2020
Merged
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
docs(app-delivery): Fix URL to pipelines readme
4ff3acc 
fixes aws#10984
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
docs(app-delivery): Fix URL to pipelines readme
fd40d36 
fixes aws#10984
@mergify mergify bot closed this as completed in #10985 Oct 21, 2020
mergify bot pushed a commit that referenced this issue Oct 21, 2020
@christophgysin
docs(app-delivery): Fix URL to pipelines readme (#10985)
da57d61 
fixes #10984


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/app-delivery Related to the app-delivery CI-CD package documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(app-delivery): Fix URL to pipelines readme christophgysin/aws-cdk
2 participants
@skinny85 @christophgysin