Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apigatewayv2] http api - support vpc link #10119

Closed
nija-at opened this issue Sep 2, 2020 · 2 comments · Fixed by #10531
Closed

[apigatewayv2] http api - support vpc link #10119

nija-at opened this issue Sep 2, 2020 · 2 comments · Fixed by #10531
Assignees
@nija-at
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@nija-at
Copy link
Contributor

nija-at commented Sep 2, 2020

Support VPC link resource - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-vpclink.html

This is a 🚀 Feature Request
@nija-at nija-at added p1 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 labels Sep 2, 2020
@nija-at nija-at self-assigned this Sep 2, 2020
@nija-at nija-at mentioned this issue Sep 2, 2020
Closed
2 tasks
@ayush987goyal ayush987goyal mentioned this issue Sep 25, 2020
Merged
@ayush987goyal
Copy link
Contributor

Added a PR #10531 to address this.

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 25, 2020
@mergify mergify bot closed this as completed in #10531 Oct 23, 2020
mergify bot pushed a commit that referenced this issue Oct 23, 2020
@ayush987goyal
feat(apigatewayv2): vpc link and private integrations (#10531)
0537598 
VpcLink and HttpProxyPrivateIntegration.

References in AWS docs:
[VpcLink](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-vpclink.html)
[Integration-1](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-private.html)
[Integration-2](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-integration.html#cfn-apigatewayv2-integration-connectiontype)

closes #10119 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@nija-at nija-at mentioned this issue Oct 29, 2020
Merged
mergify bot pushed a commit that referenced this issue Oct 30, 2020
feat(apigatewayv2): vpc link and private integrations (#11198)
e87a6a3 
This reverts commit 65be3a0.
Original PR: #10531
Co-authored-by: Ayush Goyal <[email protected]>
relates #10119

This commit was previously reverted due to a bug in jsii - aws/jsii#1947
and aws/jsii#1830. This has been fixed in jsii version 1.14.0.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): vpc link and private integrations
3 participants
@ayush987goyal @nija-at @SomayaB