fix(aws-codecommit): make the onCommit CloudWatch Event respect creat…

…ing the branch as well. (#1320) Without this change, if the repository was created through the CDK, the first push of a branch (to create it) would not trigger the onCommit Event.
aws · Dec 12, 2018 · cb1aed9 · cb1aed9
1 parent 62b7941
commit cb1aed9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/packages/@aws-cdk/aws-codebuild/test/integ.project-events.expected.json b/packages/@aws-cdk/aws-codebuild/test/integ.project-events.expected.json
@@ -27,6 +27,7 @@
           ],
           "detail": {
             "event": [
+              "referenceCreated",
               "referenceUpdated"
             ],
             "referenceName": [
@@ -386,4 +387,4 @@
       }
     }
   }
-}
+}
diff --git a/packages/@aws-cdk/aws-codecommit/lib/repository.ts b/packages/@aws-cdk/aws-codecommit/lib/repository.ts
@@ -104,7 +104,7 @@ export abstract class RepositoryRef extends cdk.Construct {
 
   /**
    * Defines a CloudWatch event rule which triggers when a reference is
-   * created (i.e. a new brach/tag is created) to the repository.
+   * created (i.e. a new branch/tag is created) to the repository.
    */
   public onReferenceCreated(name: string, target?: events.IEventRuleTarget, options?: events.EventRuleProps) {
     const rule = this.onStateChange(name, target, options);
@@ -114,11 +114,11 @@ export abstract class RepositoryRef extends cdk.Construct {
 
   /**
    * Defines a CloudWatch event rule which triggers when a reference is
-   * updated (i.e. a commit is pushed to an existig branch) from the repository.
+   * updated (i.e. a commit is pushed to an existing or new branch) from the repository.
    */
   public onReferenceUpdated(name: string, target?: events.IEventRuleTarget, options?: events.EventRuleProps) {
     const rule = this.onStateChange(name, target, options);
-    rule.addEventPattern({ detail: { event: [ 'referenceUpdated' ] } });
+    rule.addEventPattern({ detail: { event: [ 'referenceCreated', 'referenceUpdated' ] } });
     return rule;
   }
 

diff --git a/...cdk/aws-codepipeline/test/integ.pipeline-code-build-multiple-inputs-outputs.expected.json b/...cdk/aws-codepipeline/test/integ.pipeline-code-build-multiple-inputs-outputs.expected.json
@@ -27,6 +27,7 @@
           ],
           "detail": {
             "event": [
+              "referenceCreated",
               "referenceUpdated"
             ],
             "referenceName": [
@@ -599,4 +600,4 @@
       }
     }
   }
-}
+}
diff --git a/packages/@aws-cdk/aws-codepipeline/test/integ.pipeline-code-commit.expected.json b/packages/@aws-cdk/aws-codepipeline/test/integ.pipeline-code-commit.expected.json
@@ -27,6 +27,7 @@
           ],
           "detail": {
             "event": [
+              "referenceCreated",
               "referenceUpdated"
             ],
             "referenceName": [
@@ -289,4 +290,4 @@
       }
     }
   }
-}
+}