Skip to content

Commit

Permalink
chore: fix github actions name and dependencies (#12919)
Browse files Browse the repository at this point in the history
Github actions for v2 are failing because of a dependency definition on
an incorrect name. See [failures].

Further, the dependency is incorrect. The 'auto-approve' job needs to
run on PRs besides forward merges.

Fix Github action names and remove the incorrect dependency.

[failures]: https://github.com/aws/aws-cdk/actions/runs/547681911
  • Loading branch information
Niranjan Jayakar authored Feb 8, 2021
1 parent 0f718b2 commit 6de792c
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/v2-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ on:

jobs:
# Run yarn pkglint on merge forward PRs and commit the results
checkout:
name: pkglint
pkglint:
if: contains(github.event.pull_request.labels.*.name, 'pr/forward-merge')
runs-on: ubuntu-latest
steps:
Expand All @@ -36,9 +35,7 @@ jobs:

# Approve automated PRs
# Only approve! mergify takes care of the actual merge.
approve:
name: auto-approve
needs: pkglint
auto-approve:
if: >
github.event.pull_request.user.login == 'aws-cdk-automation'
&& contains(github.event.pull_request.labels.*.name, 'pr/auto-approve')
Expand Down

0 comments on commit 6de792c

Please sign in to comment.