Skip to content

Commit

Permalink
feat(eks): update nodegroup gpu check (#32715)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes #31347.

### Reason for this change


The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: `instanceTypes of different architectures is not allowed`.

### Description of changes


* (eks) Fixes the `isGpuInstanceType` check
  * G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group

### Description of how you validated changes


Wrote unit tests for the `isGpuInstanceType` function

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

Duplicate of #31445, originally authored by @ [AlexKaracaoglu](https://github.com/AlexKaracaoglu)

Co-authored-by: Alex Karacaoglu [email protected]

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
paulhcsun authored Jan 6, 2025
1 parent f809b94 commit 693afea
Show file tree
Hide file tree
Showing 33 changed files with 719 additions and 384 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading

0 comments on commit 693afea

Please sign in to comment.