-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(eks): update nodegroup gpu check (#32715)
### Issue # (if applicable) Closes #31347. ### Reason for this change The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: `instanceTypes of different architectures is not allowed`. ### Description of changes * (eks) Fixes the `isGpuInstanceType` check * G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group ### Description of how you validated changes Wrote unit tests for the `isGpuInstanceType` function ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- Duplicate of #31445, originally authored by @ [AlexKaracaoglu](https://github.com/AlexKaracaoglu) Co-authored-by: Alex Karacaoglu [email protected] *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
33 changed files
with
719 additions
and
384 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...54518518480c0d9fb344a098/helm/__init__.py → ...75ef3b79df543b7538da9c81/helm/__init__.py
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions
6
...600ed16668222a0705b6d1a/__entrypoint__.js → ...4bc1c09c60ef9cb02f562ca/__entrypoint__.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
File renamed without changes.
55 changes: 0 additions & 55 deletions
55
....snapshot/asset.1eaf141d4012ab0977a33bdf864ebbc6aa869a607e97fab6cd231fe6ef503aec/index.js
This file was deleted.
Oops, something went wrong.
184 changes: 0 additions & 184 deletions
184
...pshot/asset.46fb886516825167db3571f1ed91110fc6163ce20ee26fdb097c2c983f25fcd6/framework.js
This file was deleted.
Oops, something went wrong.
54 changes: 0 additions & 54 deletions
54
...s.snapshot/asset.46fb886516825167db3571f1ed91110fc6163ce20ee26fdb097c2c983f25fcd6/util.js
This file was deleted.
Oops, something went wrong.
Binary file renamed
BIN
+1.5 MB
...901edd66d1367f617c2a01ac6e86ca2b7eb84.zip → ...012b131bdc34fcf2bc16eb4170e04772fddb1.zip
Binary file not shown.
10 changes: 5 additions & 5 deletions
10
...20ee26fdb097c2c983f25fcd6/cfn-response.js → ...f28cf423c3afd3cbaf0662e6b/cfn-response.js
Large diffs are not rendered by default.
Oops, something went wrong.
File renamed without changes.
185 changes: 185 additions & 0 deletions
185
...pshot/asset.9ebfbf95d93057cd65617a9d6f72a0e7dd31520f28cf423c3afd3cbaf0662e6b/framework.js
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.