fix: serverlessV2MaxCapacity should not be set to 0.5

aws · Nov 21, 2024 · 595510c · 595510c
1 parent 5178050
commit 595510c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/aws-cdk-lib/aws-rds/lib/cluster.ts b/packages/aws-cdk-lib/aws-rds/lib/cluster.ts
@@ -985,8 +985,8 @@ abstract class DatabaseClusterNew extends DatabaseClusterBase {
   }
 
   private validateServerlessScalingConfig(): void {
-    if (this.serverlessV2MaxCapacity > 256 || this.serverlessV2MaxCapacity < 0.5) {
-      throw new Error('serverlessV2MaxCapacity must be >= 0.5 & <= 256');
+    if (this.serverlessV2MaxCapacity > 256 || this.serverlessV2MaxCapacity < 1) {
+      throw new Error('serverlessV2MaxCapacity must be >= 1 & <= 256');
     }
 
     if (this.serverlessV2MinCapacity > 256 || this.serverlessV2MinCapacity < 0.5) {
@@ -997,9 +997,6 @@ abstract class DatabaseClusterNew extends DatabaseClusterBase {
       throw new Error('serverlessV2MaxCapacity must be greater than serverlessV2MinCapacity');
     }
 
-    if (this.serverlessV2MaxCapacity === 0.5 && this.serverlessV2MinCapacity === 0.5) {
-      throw new Error('If serverlessV2MinCapacity === 0.5 then serverlessV2MaxCapacity must be >=1');
-    }
     const regexp = new RegExp(/^[0-9]+\.?5?$/);
     if (!regexp.test(this.serverlessV2MaxCapacity.toString()) || !regexp.test(this.serverlessV2MinCapacity.toString())) {
       throw new Error('serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments, received '+

diff --git a/packages/aws-cdk-lib/aws-rds/test/cluster.test.ts b/packages/aws-cdk-lib/aws-rds/test/cluster.test.ts
@@ -114,11 +114,10 @@ describe('cluster new api', () => {
     });
 
     test.each([
-      [0.5, 300, /serverlessV2MaxCapacity must be >= 0.5 & <= 256/],
-      [0.5, 0, /serverlessV2MaxCapacity must be >= 0.5 & <= 256/],
+      [0.5, 300, /serverlessV2MaxCapacity must be >= 1 & <= 256/],
+      [0.5, 0, /serverlessV2MaxCapacity must be >= 1 & <= 256/],
       [0, 1, /serverlessV2MinCapacity must be >= 0.5 & <= 256/],
       [300, 1, /serverlessV2MinCapacity must be >= 0.5 & <= 256/],
-      [0.5, 0.5, /If serverlessV2MinCapacity === 0.5 then serverlessV2MaxCapacity must be >=1/],
       [10.1, 12, /serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments/],
       [12, 12.1, /serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments/],
       [5, 1, /serverlessV2MaxCapacity must be greater than serverlessV2MinCapacity/],