Skip to content

Commit

Permalink
fix(aws_route53): cannot use CfnParameter.valueAsNumber for L2 Record…
Browse files Browse the repository at this point in the history
…Set weight (#31823)

### Issue # (if applicable)

Closes #31810.

### Reason for this change

Could not use CfnParameter.valueAsNumber for L2 RecordSet weight.

### Description of changes

Adding validation of weight property as a potential Token in RecordSet constructor.

### Description of how you validated changes

Added unit and integration test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
nicholaschiasson authored Oct 31, 2024
1 parent 09052c2 commit 14561ac
Show file tree
Hide file tree
Showing 11 changed files with 894 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 14561ac

Please sign in to comment.