Implement Prometheus instrumentation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranmeduri
reviewed
Nov 6, 2019
| @@ -231,6 +246,11 @@ func (v *VirtualNode) BackendsSet() set.Set { | |||
|
|
|||
| // GetVirtualNode calls describe virtual node. | |||
| func (c *Cloud) GetVirtualNode(ctx context.Context, name string, meshName string) (*VirtualNode, error) { | |||
| begin := time.Now() | |||
| defer func() { | |||
| c.stats.SetRequestDuration("virtual_node", name, "get", time.Since(begin)) | |||
There was a problem hiding this comment.
is it better to normalize? <meshName>.<virtualNodeName>
There was a problem hiding this comment.
I would not use dots in Prometheus metrics, we could add the mesh as a separate label if you want.
There was a problem hiding this comment.
Agreed with @stefanprodan, let's add as a separate label.
There was a problem hiding this comment.
I would like to do this and add more instrumentation in a followup PR. The metrics as they are now are sufficient for the Grafana dashboard I made in aws/eks-charts#30
|
Can you rebase? |
nckturner
approved these changes
Nov 6, 2019
- appmesh_mesh_state gauge - appmesh_virtual_node_state gauge - appmesh_virtual_service_state gauge - appmesh_api_request_duration_seconds histogram Signed-off-by: stefanprodan <[email protected]>
Records the duration of App Mesh API calls based on object kind, name and operation type. The operation type can be get, create, update or delete. The object kind can be mesh, virtual node, virtual route, virtual router or virtual service. Signed-off-by: stefanprodan <[email protected]>
Record mesh, virtual node and virtual service operations as gauges. For each object the gauge value represents the current state, 1 means that the object is active while 0 means that the object has been deleted. Signed-off-by: stefanprodan <[email protected]>
Signed-off-by: stefanprodan <[email protected]>
|
@nckturner rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation for the controller App Mesh API calls and exports Prometheus metrics for meshes, virtual nodes and virtual services.
Metrics:
appmesh_mesh_state{name}gaugeappmesh_virtual_node_state{name, mesh}gaugeappmesh_virtual_service_state{name, mesh}gaugeappmesh_api_request_duration_seconds{kind, object, operation}histogramThe controller instrumentationr records mesh, virtual node and virtual service operations as gauges. For each object the gauge value represents the current state,
1means that the object is active while0means that the object has been deleted.The API client instrumentation records the duration of App Mesh API calls based on object kind, name and operation type. The operation type can be get, create, update or delete. The object kind can be mesh, virtual node, virtual route, virtual router or virtual service.
The
appmesh_api_request_duration_secondshistogram helps track issues like #96Fix: #98
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.