Grpc/Http2 support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:aws/aws-app-mesh-controller-for-k8s: Release v0.2.0 Show CircleCI status for master branch only Add go fmt check to CI and fix code formatting Fix virtual node condition message labeling
…or-k8s into grpc * 'master' of github.com:skiyani/aws-app-mesh-controller-for-k8s: Release v0.2.0 Show CircleCI status for master branch only Add go fmt check to CI and fix code formatting Fix virtual node condition message labeling
stefanprodan
suggested changes
Oct 22, 2019
* 'master' of github.com:aws/aws-app-mesh-controller-for-k8s: Added error message to run 'go mod download' when codegen pkg is missing under GOPATH Added go mod download step Adding verify-codegen step to circleci Added verify-codegen Added tools.go Fix code-gen to deal with GOPATH and go.mod setups. # Conflicts: # go.mod # go.sum
…or-k8s into grpc * 'master' of github.com:skiyani/aws-app-mesh-controller-for-k8s: Added error message to run 'go mod download' when codegen pkg is missing under GOPATH Added go mod download step Adding verify-codegen step to circleci Added verify-codegen Added tools.go Fix code-gen to deal with GOPATH and go.mod setups.
skiyani
changed the title
|
This is great! After @stefanprodan reviews again, can you squash? |
|
@skiyani LGTM, after you squash I'll merge. |
nckturner
approved these changes
Oct 28, 2019
|
Nvm, just did a squash and merge from here, I'm a bit slow on the uptake of github's fancy features. |
|
Thanks @nckturner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add support for grpc and http2 routes. Add aws appmesh preview go sdk
App Mesh CRD update checklist
Testing
K8s http2 and grpc walkthroughs aws-app-mesh-examples#224
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.