Improve demo #9
Merged
Improve demo #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/color.yaml
Outdated
| @@ -81,17 +112,18 @@ spec: | |||
| prefix: / | |||
| action: | |||
| weightedTargets: | |||
| - virtualNodeName: colorteller-vn | |||
| - virtualNodeName: colorteller | |||
There was a problem hiding this comment.
The namespace prefix -appmesh-demo is missing from all virtual nodes.
| --- | ||
| apiVersion: appmesh.k8s.aws/v1alpha1 | ||
| kind: VirtualService | ||
| metadata: | ||
| name: colorteller.default.svc.cluster.local | ||
| name: colorteller.appmesh-demo.svc.cluster.local | ||
| namespace: appmesh-demo | ||
| spec: | ||
| meshName: color-mesh | ||
| virtualRouter: |
There was a problem hiding this comment.
The virtual router name and the route name should follow the namespace prefix convention.
examples/color.yaml
Outdated
| name: appmesh-demo | ||
| spec: | ||
| finalizers: | ||
| - kubernetes |
There was a problem hiding this comment.
The kubernetes finalizer can be removed.
* Use non-default namespace * Integrate with inject (now requires inject to be deployed for demo) * Add namespace suffix convention to virtual node, router and route names.
|
Addressed @stefanprodan's comments. |
stefanprodan
approved these changes
Mar 18, 2019
jeremymill
added a commit
to jeremymill/aws-app-mesh-controller-for-k8s
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.