Update routes when virtual service changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefanprodan <[email protected]>
Signed-off-by: stefanprodan <[email protected]>
- detect changes in prefix and weighted targets - fix route insert bug when all targets would get the same weight Signed-off-by: stefanprodan <[email protected]>
|
Awesome! I have something similar which I'm working on which also does some clean-up. I'll open a PR shortly as well and we can compare. |
Signed-off-by: stefanprodan <[email protected]>
|
@nckturner I've looked over your PR and it covers the route updates commit from this PR. I would merge this one first to get the namespace and panic fixes. |
nckturner
approved these changes
Mar 14, 2019
jeremymill
added a commit
to jeremymill/aws-app-mesh-controller-for-k8s
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the AppMesh routes in sync with the virtual service definition.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.