Disambiguate router names in example #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcelenza yes they were intended to be optional. I.e., if not specified default to service name. Can you create an issue for the broader bug? |
nckturner
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current example template referenced in https://github.com/aws/aws-app-mesh-examples/blob/master/walkthroughs/eks/base.md has an error that results in the colorteller virtual router mapping to the color gateway's route.
This change disambiguates the routers and routes by naming the routers accordingly.
Are router names intended to be optional in the controller? If so, there is a broader bug here that warrants a separate pull request.
Testing:
Followed the guide at the walkthrough link above, observed 500 error and invalid router to route mapping in App Mesh configuration. Updated with proposed changes and mapping works as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.