Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mTLS parameters in controller helm chart #434

Merged
merged 1 commit into from
Feb 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/helm/appmesh-controller/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ eksctl create iamserviceaccount --cluster $CLUSTER_NAME \
```

Deploy appmesh-controller

**Note:** To enable mTLS via SDS(SPIRE), please set "sds.enabled=true".

```sh
helm upgrade -i appmesh-controller eks/appmesh-controller \
--namespace appmesh-system \
Expand Down Expand Up @@ -157,6 +160,9 @@ eksctl create iamserviceaccount --cluster $CLUSTER_NAME \
```

Deploy appmesh-controller

**Note:** mTLS via SDS(SPIRE) is not supported on Fargate.

```sh
helm upgrade -i appmesh-controller eks/appmesh-controller \
--namespace appmesh-system \
Expand Down Expand Up @@ -310,6 +316,8 @@ Parameter | Description | Default
`image.tag` | image tag | `<VERSION>`
`image.pullPolicy` | image pull policy | `IfNotPresent`
`log.level` | controller log level, possible values are `info` and `debug` | `info`
`sds.enabled` | If `true`, SDS will be enabled in Envoy | `false`
`sds.udsPath` | Unix Domain Socket Path of the SDS Provider(SPIRE in the current release) | `/run/spire/sockets/agent.sock`
`resources.requests/cpu` | pod CPU request | `100m`
`resources.requests/memory` | pod memory request | `64Mi`
`resources.limits/cpu` | pod CPU limit | `2000m`
Expand Down
2 changes: 2 additions & 0 deletions config/helm/appmesh-controller/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ spec:
- --envoy-admin-access-port={{ .Values.sidecar.envoyAdminAccessPort }}
- --envoy-admin-access-log-file={{ .Values.sidecar.envoyAdminAccessLogFile }}
- --preview={{ .Values.preview }}
- --enable-sds={{ .Values.sds.enabled }}
- --sds-uds-path={{ .Values.sds.udsPath }}
{{- if .Values.cloudMapCustomHealthCheck.enabled }}
- --enable-custom-health-check=true
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions config/helm/appmesh-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ cloudMapDNS:
# cloudMapDNS.ttl if set will use this global ttl value
ttl: 300

sds:
# sds.enabled: `true` if SDS based mTLS support needs to be enabled in envoy
enabled: false
#sds.udsPath: UDS Path of the SDS Provider. Default value is tied to SPIRE.
udsPath: /run/spire/sockets/agent.sock

serviceAccount:
# serviceAccount.create: Whether to create a service account or not
create: true
Expand Down