Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md #36

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

geremyCohen
Copy link
Contributor

Adding delete permissions, without them, CRD controller will not be able to delete App Mesh resources.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adding delete permissions, without them, CRD controller will not be able to delete App Mesh resources.
@nckturner nckturner self-assigned this Apr 4, 2019
@jqmichael
Copy link
Contributor

LGTM

@jqmichael
Copy link
Contributor

BTW, it might be easier to use appmesh:* at this point.
The only non-touched permissions are TagResource and UntagResource
https://docs.aws.amazon.com/app-mesh/latest/APIReference/Welcome.html

@nckturner
Copy link
Contributor

@jqmichael @geremyCohen Let's not use appmesh:*. Its better to be explicit, because appmesh:* will likely include more permissions in the future, and it's less visible to users what they are allowing the controller to do.

@nckturner nckturner merged commit 32e3977 into aws:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants