Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message to compile when Node is missing #239

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add error message to compile when Node is missing #239

merged 1 commit into from
Dec 13, 2024

Conversation

lrbison
Copy link
Contributor

@lrbison lrbison commented Dec 3, 2024

Description of changes:

Add error message to compile when Node is missing

The message:

   Compiling aperf v0.1.0 (/fsx/lrbison/code/aperf)
error: failed to run custom build command for `aperf v0.1.0 (/fsx/lrbison/code/aperf)`

Caused by:
  process didn't exit successfully: `/fsx/lrbison/code/aperf/target/debug/build/aperf-d4acbb2dac42850a/build-script-build` (exit status: 1)
  --- stdout
  cargo:rustc-env=VERGEN_GIT_SHA=c88030f
  cargo:rerun-if-changed=.git/HEAD
  cargo:rerun-if-changed=.git/refs/heads/build
  cargo:rerun-if-changed=build.rs
  cargo:rerun-if-env-changed=VERGEN_IDEMPOTENT
  cargo:rerun-if-env-changed=SOURCE_DATE_EPOCH
  cargo:rerun-if-changed=package.json
  cargo:rerun-if-changed=package-lock.json
  Build requires npm, but it was not found.  Please install Node >= 16.16.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lrbison lrbison requested a review from a team as a code owner December 3, 2024 21:56
wash-amzn
wash-amzn reviewed Dec 6, 2024
View reviewed changes
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
wash-amzn
wash-amzn reviewed Dec 11, 2024
View reviewed changes
build.rs Outdated Show resolved Hide resolved
janaknat
janaknat reviewed Dec 12, 2024
View reviewed changes
build.rs
if !status.success() {
std::process::exit(1);
match Command::new("npm").arg("install").spawn() {
Err(_proc) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err(_) should also work.

@wash-amzn wash-amzn merged commit 660c6f6 into aws:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaknat janaknat janaknat left review comments

@wash-amzn wash-amzn wash-amzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrbison @janaknat @wash-amzn