Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENI tagging - SG for PODs #333

Open
nicoaws opened this issue Nov 1, 2023 · 10 comments
Open

ENI tagging - SG for PODs #333

nicoaws opened this issue Nov 1, 2023 · 10 comments
Labels
enhancement New feature or request feature request Request for a new feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicoaws
Copy link

nicoaws commented Nov 1, 2023

When using SG for PODS, an ENI gets attached to each POD.

AWS Network Firewall supports tag-based filtering with ENIs as resources.

This request is to enable ENI tagging by the VPC CNI by the use of annotations so that AWS Network Firewall can leverage those to filter traffic.

Tags could be things like:

  • namespace
  • VPC ID
  • subnet ID
  • Security Group ID
  • custom tags specified by user in annotations
@nicoaws nicoaws added enhancement New feature or request feature request Request for a new feature labels Nov 1, 2023
@jayanthvn
Copy link

This would need a knob. We can get pod name and ns and derive replica set name. Any custom tag should be passed thru the env and this will be cluster level config.

@jayanthvn jayanthvn added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 1, 2023
@nicoaws
Copy link
Author

nicoaws commented Nov 1, 2023

Can custom tags not be passed via annotations? The idea is that certain pods should have ENIs tagged in some way and other pods in another way.

@jdn5126
Copy link
Contributor

jdn5126 commented Nov 7, 2023

@nicoaws is the goal to place pods with certain annotations/labels behind ENIs with certain tags?

@nicoaws
Copy link
Author

nicoaws commented Nov 7, 2023

no the goal is to be able to tag pod ENIs by using annotations

@jdn5126
Copy link
Contributor

jdn5126 commented Nov 7, 2023

no the goal is to be able to tag pod ENIs by using annotations

Ok, so you are asking about tagging the branch ENIs that are used for pods with security groups, correct? As normal ENIs can have additional tags added by setting the ADDITIONAL_ENI_TAGS: https://github.com/aws/amazon-vpc-cni-k8s#additional_eni_tags-v160 environment variable

@nicoaws
Copy link
Author

nicoaws commented Nov 7, 2023

exactly!

@jdn5126
Copy link
Contributor

jdn5126 commented Nov 17, 2023

Since branch ENIs are created by the VPC Resource Controller, the tagging would have to happen there. I will transfer this issue to that repo

@jdn5126 jdn5126 transferred this issue from aws/amazon-vpc-cni-k8s Nov 17, 2023
@haouc
Copy link
Contributor

haouc commented Nov 18, 2023

VPC ID
subnet ID
Security Group ID

The branch ENI assigned for pods is created with subnet and security group, thus VPC ID/Subnet ID/Security Group ID are available for every branch interface. I am not sure if your use cases with AWS Network Firewall have to use interfaces' tag and also how tagging with those info could help in general.

Customized tagging could be a bit challenging since this EKS managed service is currently not taking customized configurations yet. Please create an issue at the roadmap if you think this is a feature could help and should be supported by AWS EKS. Thanks

@nicoaws
Copy link
Author

nicoaws commented Nov 18, 2023 via email

@ivanovit
Copy link

ivanovit commented Dec 4, 2023

We also need a way to pass custom tags to ENI. The requirement is to tag all resources with specific tags for compliance purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request for a new feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants