Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context and user agents to EC2 requests #979

Merged
merged 1 commit into from
May 19, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented May 19, 2020

Fix for issue #975

Description of changes:

  • Add "amazon-vpc-cni-k8s" to the request user agent.
  • Add background context to all EC2 calls
  • Log UnassignPrivateIpAddresses with the actual EC2 API call name

Test
Sample user agent output from logs:

aws-sdk-go/1.30.4 (go1.13.10; linux; amd64) amazon-vpc-cni-k8s

In Grafana:

Screen Shot 2020-05-18 at 22 06 27

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested review from wongma7 and nckturner May 19, 2020 05:17
Copy link
Member

@wongma7 wongma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, that was fast!

@mogren mogren merged commit d8ca7e9 into aws:master May 19, 2020
@mogren mogren deleted the add-user-agent branch August 24, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants