-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run conformance test as part of PR/Release certification #851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, Balaji! Just a couple small requests inline.
Thanks!
-jay
@@ -50,3 +54,25 @@ workflows: | |||
- integration_test: | |||
requires: | |||
- hold | |||
|
|||
# runs integration test when new git tag is pushed. | |||
run-test-on-tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this and the nightly-test-run job, you will want to set:
environment:
RUN_CONFORMANCE: "true"
2264ffd
to
554694b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 :)
554694b
to
aa3790b
Compare
* Run conformance testing as part of integration test. * Trigger integration test on new tags. * Add nightly runs on master branch
aa3790b
to
e9c3f7f
Compare
For some reason, circleCI was triggering build in my personal account instead of triggering in cni repo aws account. For now, stopped builds on my personal acct and its now building in cni repo aws account. |
Description of changes:
This changes updates CircleCI config.yaml to add following functionalities:
Addresses Issue: #686
Upcoming changes:
Ran this on my personal repo - https://circleci.com/api/v1.1/project/github/SaranBalaji90/amazon-vpc-cni-k8s-1/78/output/108/0?file=true&allocation-id=5e552aea36810238d4b33f5d-0-build%2F50024F6D
Adding some of my learning here to help others in future:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.