Additional tags to ENI #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
suggested changes
Nov 26, 2019
|
@nithu0115 please be aware of #726. If that merges first, you'll need to rebase and fix conflicts. |
|
Thanks for the review @jaypipes . Added changes as your comments. |
jaypipes
approved these changes
Nov 26, 2019
mogren
reviewed
Nov 26, 2019
mogren
reviewed
Nov 26, 2019
jaypipes
approved these changes
Nov 27, 2019
|
|
||
| Metadata applied to ENI help you categorize and organize your resources for billing or other purposes. Each tag consists of a custom-defined key and an optional value. Tag keys can have a maximum character length of 128 characters. Tag values can have a maximum length of 256 characters. These tags will be added to all ENIs on the host. | ||
|
|
||
| Important: Custom tags should not contain `k8s.amazonaws.com` prefix as it is reserved. If the tag has `k8s.amazonaws.com` string, tag addition will ignored. |
| tagKey2 := "tagKey2" | ||
| tagValue1 := "tagValue1" | ||
| tagValue2 := "tagValue2" | ||
| tagKey3 := "cluster.k8s.amazonaws.com/name" |
There was a problem hiding this comment.
Good, you added a test that this one is stripped.
|
|
||
| for key, value := range tagsMap { | ||
| keyPrefix := reservedTagKeyPrefix | ||
| if strings.Contains(key, keyPrefix) { |
There was a problem hiding this comment.
This is kind of misleading (same goes for the error message below) as this is not a prefix check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#643
Description of changes:
This feature allows you to add additional tags to ENIs created. Metadata applied to ENI help you categorize and organize your resources for billing or other purposes. Each tag consists of a custom-defined key and an optional value. Tag keys can have a maximum character length of 128 characters. Tag values can have a maximum length of 256 characters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.