Hide health check output #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsiddharth
approved these changes
Aug 5, 2019
| } | ||
|
|
||
| waitIPamDServing () { | ||
| until grpcHealthCheck; do | ||
| echo "Waiting for ipamd health check"; | ||
| sleep 1; | ||
| done | ||
| echo "Ipamd is up and serving" |
There was a problem hiding this comment.
nit: s/Ipamd is up and serving/L-IPAMD is up and ready to serve/g
| /app/aws-k8s-agent & | ||
|
|
||
| # Check ipamd health | ||
| echo "Checking if ipamd is serving" | ||
| waitIPamDServing | ||
|
|
||
| echo "===== Copying AWS CNI plugin and config =========" | ||
| echo "Copying AWS CNI plugin and config" |
There was a problem hiding this comment.
nit: Break this down into two steps
- Moving the cni-plugin
- Moving the cni-conf
There was a problem hiding this comment.
Will fix in master branch.
tiffanyfay
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #568
Description of changes:
We are not interested in the log output of the health check, just that it succeeds. Hiding the verbose output from the
grpc_health_probe.Sample output when starting up:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.