Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calico version to v3.8.1 #554

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Update Calico version to v3.8.1 #554

merged 2 commits into from
Aug 8, 2019

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Aug 1, 2019

Description of changes:

  • Update Calico image tags from v3.3.6 to v3.8.1
  • Add required RBAC changes and CRDs for v3.8.1
  • Remove deprecated apiVersions and fields.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lmm
Copy link
Contributor Author

lmm commented Aug 1, 2019

I notice now that some of changes I've made are also in #504

@mogren mogren added this to the v1.6 milestone Aug 1, 2019
@mogren mogren self-requested a review August 1, 2019 06:13
@mogren
Copy link
Contributor

mogren commented Aug 1, 2019

Hey @lmm, thanks a lot. I'll take a look at this before making a v1.6.0 release

@tmjd
Copy link
Contributor

tmjd commented Aug 6, 2019

@mogren WDYT about making these changes for 1.5.2 also (which I see an RC is up for)?
When would they need to be submitted by?

@mogren
Copy link
Contributor

mogren commented Aug 7, 2019

@tmjd Hey, sorry, already cut the v1.5.2 release. Will try to get v1.6.0 out before the end of this month.

Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and the changes seem fine. Thanks for updating this config!

@mogren mogren merged commit a3045f8 into aws:master Aug 8, 2019
@lmm lmm deleted the update-calico-version branch October 11, 2019 14:09
@nickdgriffin
Copy link

This is still listed as being in the 1.5.3 release, but that doesn't seem to be the case for the upgrade to v3.8.1 which looks to have been pushed to 1.6.0.

@mogren
Copy link
Contributor

mogren commented Oct 14, 2019

@nickdgriffin Hey, thanks for catching this, I'll update the configs.

This was referenced Oct 14, 2019
@nickdgriffin
Copy link

@mogren No problem, was just reviewing what I needed for an upgrade and noticed the discrepancy - thanks for sorting!

@nickdgriffin
Copy link

@mogren I think it's needed on the 1.5.4 branch too, as that's missing it. This also means that anyone that uses the tag (like I did) to get the appropriate version will still get the old one unless they are remade.

@mogren
Copy link
Contributor

mogren commented Oct 15, 2019

@nickdgriffin I had it locally, forgot to push. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calico Calico integration issue enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants