Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeconfig lookup order for eksctl nodegroups #513

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

dkeightley
Copy link
Contributor

During eksctl bootstrap, the /etc/systemd/system/kubelet.service file still exists, although kubelet.service.d/10-eksclt.al2.conf and /etc/eksctl/kubeconfig.yaml are created and used [1].

This causes errors when running the aws-cni-support.sh script due to the precedence of looking up the kubeconfig file.

error: unable to read certificate-authority /etc/kubernetes/pki/ca.crt for kubernetes due to open /etc/kubernetes/pki/ca.crt: no such file or directory

[1] https://github.com/weaveworks/eksctl/blob/master/pkg/nodebootstrap/userdata_al2.go

Issue #, if available:

Description of changes:

Reversed the lookup to first match eksctl bootstrapped nodes to avoid errors retrieving introspection data.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

During eksctl bootstrap, the `/etc/systemd/system/kubelet.service` file still exists, although `kubelet.service.d/10-eksclt.al2.conf` and `/etc/eksctl/kubeconfig.yaml` are created and used.

This causes errors when running the `aws-cni-support.sh` script due to the precedence of looking up the kubeconfig file.

`error: unable to read certificate-authority /etc/kubernetes/pki/ca.crt for kubernetes due to open /etc/kubernetes/pki/ca.crt: no such file or directory`
@mogren mogren self-requested a review June 25, 2019 04:05
@mogren mogren added this to the v1.6 milestone Jun 25, 2019
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for submitting a PR!

@mogren mogren merged commit 723dd5a into aws:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants