Avoid unbound variable error in CNI 1.4 RC1 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/opt/cni/bin/aws-cni-support.sh: line 35: KUBECONFIG: unbound variable set -u will abort here so see if the parameter is set and non-empty using an empty default value.
mogren
approved these changes
Apr 8, 2019
This was referenced Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to the latest release candidate, SSHing into the host machines, running as root /opt/cni/bin/aws-cni-support.sh gets the following error:
set -uwill abort here so in the bracket test, see if the parameter is set and non-empty using an empty default value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.