Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run yum clean all to reduce image size #351

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Run yum clean all to reduce image size #351

merged 1 commit into from
Mar 21, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Mar 21, 2019

Description of changes:

Clean up yum files when building the Docker image.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren added this to the v1.4 milestone Mar 21, 2019
hmizuma
hmizuma approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@hmizuma hmizuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduces image size by quite a lot. LGTM

tiffanyfay
tiffanyfay approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@tiffanyfay tiffanyfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Big change!

@mogren mogren merged commit 0a615cb into aws:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyfay tiffanyfay tiffanyfay approved these changes

@hmizuma hmizuma hmizuma approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mogren @hmizuma @tiffanyfay