fix(chart): Switch base64 encoded cniConfig.fileContents to the binaryData #2552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#2551
What does this PR do / Why do we need it:
Currently it's stored as a base64 encoded JSON and the VPC CNI app doesn't decode this base64 and fails.
This change switched the ConfigMap from
data
to thebinaryData
which natively will decode base64 from the ConfigMap with no need to introduce any changes to the app itself.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
After changing the
data
in ConfigMap to thebinaryData
everything works as intended:Automation added to e2e:
no
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.