Use device number 0 for primary device in unit test #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes very tiny change in unit test.
According to the comment below in pkg/awsutils/awsutils.go,
DeviceNumer 0 means primary interface.
```
// DeviceNumber is the device number of network interface
DeviceNumber int64 // 0 means it is primary interface
```
This patch changes to set primaryDevice to 0 and secDevice to 2 in
unit test.
mogren
approved these changes
Nov 27, 2018
| primaryDevice = 2 | ||
| secDevice = 0 | ||
| primaryDevice = 0 | ||
| secDevice = 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch makes very tiny change in unit test.
According to the comment below in pkg/awsutils/awsutils.go,
DeviceNumer 0 means primary interface.
amazon-vpc-cni-k8s/pkg/awsutils/awsutils.go
Lines 167 to 168 in 0736312
Hence, this patch changes to set primaryDevice to 0 and secDevice to 2 in
unit test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.