Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip delete test cluster to debug #2414

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

oliviassss
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:
Skip deleting the test cluster if failed, to debug the nightly test failure. Will revert after the fix

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@oliviassss oliviassss requested a review from a team as a code owner June 9, 2023 22:43
@M00nF1sh
Copy link
Contributor

M00nF1sh commented Jun 9, 2023

approve this, but remember to revert this commit and manually clean up test clusters in that account.

@M00nF1sh M00nF1sh merged commit 7c30943 into aws:master Jun 9, 2023
oliviassss added a commit to oliviassss/amazon-vpc-cni-k8s that referenced this pull request Jun 9, 2023
M00nF1sh pushed a commit that referenced this pull request Jun 9, 2023
jdn5126 added a commit that referenced this pull request Jun 15, 2023
* refactor canary test to access images from AWS registries (#2398)

* upgrade client-go and controller-runtime modules (#2396)

* updates for v1.13.0 release (#2400)

* chore: Added dependabot (#2403)

* dependency updates (#2412)

* deprecate ENABLE_NFTABLES and set iptables mode using iptables-wrapper script (#2402)

* update networking test agent to go1.20 and latest sys module (#2413)

* skip delete test cluster to debug (#2414)

* Revert "skip delete test cluster to debug (#2414)" (#2415)

This reverts commit 7c30943.

* authenticate to test image registry (#2417)

* update test agent image (#2419)

* update test agent hash in go.mod (#2422)

---------

Co-authored-by: Olivia Song <[email protected]>
Co-authored-by: Ellis Tarn <[email protected]>
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jun 16, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jun 16, 2023
jdn5126 added a commit that referenced this pull request Jun 16, 2023
* refactor canary test to access images from AWS registries (#2398)

* skip delete test cluster to debug (#2414)

* Revert "skip delete test cluster to debug (#2414)" (#2415)

This reverts commit 7c30943.

* authenticate to test image registry (#2417)

* fix hard-coded nitro instances (#2428)

* move authentication step from test canary script (#2429)

* node initialization must come after primary ENI's security groups are synced to cache

---------

Co-authored-by: Olivia Song <[email protected]>
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jun 16, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jun 16, 2023
jdn5126 added a commit that referenced this pull request Jul 11, 2023
* refactor canary test to access images from AWS registries (#2398)

* upgrade client-go and controller-runtime modules (#2396)

* updates for v1.13.0 release (#2400)

* chore: Added dependabot (#2403)

* dependency updates (#2412)

* deprecate ENABLE_NFTABLES and set iptables mode using iptables-wrapper script (#2402)

* update networking test agent to go1.20 and latest sys module (#2413)

* skip delete test cluster to debug (#2414)

* Revert "skip delete test cluster to debug (#2414)" (#2415)

This reverts commit 7c30943.

* authenticate to test image registry (#2417)

* update test agent image (#2419)

* update test agent hash in go.mod (#2422)

* fix hard-coded nitro instances (#2428)

* move authentication step from test canary script (#2429)

* node initialization must come after primary ENI's security groups are synced to cache (#2427)

* Add 1.27 to Rec Version Table (#2404)

* revise rec version table

* make DOCKER_ARGS a passable var from CLI builds (#2434)

Signed-off-by: jonahjon <[email protected]>

* Update Kops cluster to latest and add parameter for kops version (#2435)

* Updates instance limits including c7gn (#2438)

* Update Kops cluster to latest and add parameter for kops version (#2440)

* update image tag to v1.13.2 (#2432)

* update docs and CNI logging (#2433)

* remove default canary test run from integration tests (#2443)

* Silences nightly cron jobs for forks (#2444)

* Silences weekly cron jobs for forks (#2459)

* refactor performance tests (#2455)

* add custom-networking test covering ENIConfig objects with no security (#2445)

groups

* k8s clients only need to access corev1; add pod selector (#2463)

---------

Signed-off-by: jonahjon <[email protected]>
Co-authored-by: Olivia Song <[email protected]>
Co-authored-by: Ellis Tarn <[email protected]>
Co-authored-by: Geoffrey Cline <[email protected]>
Co-authored-by: Jonah Jones <[email protected]>
Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Matt <[email protected]>
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jul 12, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jul 12, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jul 12, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants