Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go mod download from Dockerfiles #2383

Merged
merged 1 commit into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions scripts/dockerfiles/Dockerfile.init
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,8 @@ ARG TARGETARCH
ENV GO111MODULE=on
ENV GOPROXY=direct

# Copy modules in before the rest of the source to only expire cache on module changes:
COPY go.mod go.sum ./
RUN go mod download

COPY Makefile ./
RUN make plugins && make debug-script

COPY . ./
RUN make plugins && make debug-script
RUN make build-aws-vpc-cni-init

# Build from EKS minimal base + glibc by default
Expand Down
4 changes: 0 additions & 4 deletions scripts/dockerfiles/Dockerfile.metrics
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ WORKDIR /go/src/github.com/aws/amazon-vpc-cni-k8s
ENV GO111MODULE=on
ENV GOPROXY=direct

# Copy modules in before the rest of the source to only expire cache on module changes:
COPY go.mod go.sum ./
RUN go mod download

COPY . ./
RUN make build-metrics

Expand Down
5 changes: 0 additions & 5 deletions scripts/dockerfiles/Dockerfile.release
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ ARG TARGETARCH
ENV GO111MODULE=on
ENV GOPROXY=direct

# Copy modules in before the rest of the source to only expire cache on module changes:
COPY go.mod go.sum ./
RUN go mod download

COPY Makefile ./
COPY . ./
RUN make build-aws-vpc-cni && make build-linux

Expand Down