IPv6 integration tests #1658
Merged
IPv6 integration tests #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Oct 4, 2021
|
|
||
| for _, pod := range podNetworkingValidationInput.PodList { | ||
|
|
||
| podIP, podIPNet, err := net.ParseCIDR(pod.PodIPv4Address + "/32") | ||
| podIP = pod.PodIPv4Address |
There was a problem hiding this comment.
Nit: Looks like indentation is bit off.
jayanthvn
reviewed
Oct 4, 2021
| @@ -40,8 +41,10 @@ func main() { | |||
| StartTCPServer(addr) | |||
| } else if serverMode == "udp" { | |||
| StartUDPServer(addr) | |||
| } else if serverMode == "http" { | |||
There was a problem hiding this comment.
Nit: Need to update "// Supported modes are tcp, udp" for var serverMode string on line 29
jayanthvn
reviewed
Oct 4, 2021
| // express or implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
|
|
||
| package ipv6 |
There was a problem hiding this comment.
Maybe as a follow up can we also add test cases around the new env variables? ENABLE IPV4 and IPV6?
There was a problem hiding this comment.
They are covered by UT though. In general we can't toggle these 2 env variables on a live cluster as the cluster can either be an IPv4 or an IPv6 cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature tests
What does this PR do / Why do we need it:
PR adds integration tests for IPv6 support.
Testing done on this change:
Verified the
ipv6integration test suite on an IPv6 cluster.Automation added to e2e:
Yes.
test/integration-new/cni/ipv6Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.