IPv6 Support #1587
IPv6 Support #1587
Conversation
rpc/rpc.proto
Outdated
| @@ -34,7 +38,9 @@ message AddNetworkReply { | |||
| int32 ParentIfIndex = 10; | |||
| // end of pod-eni parameters | |||
|
|
|||
| // next field: 11 | |||
| repeated string VPCv6CIDRs = 11; | |||
There was a problem hiding this comment.
Super-minor: I wouldn't bother mentioning it, but if you're going to edit this file again anyway (to give IPv6Addr a new field ID), then it would be nice to put VPCv6CIDRs next to VPCv4CIDRs for readability (still with =6 and =11 field IDs)
There was a problem hiding this comment.
Sure, I can do that.
| c.enableIpv4PrefixDelegation = false | ||
| //Let's validate if the configured combination of env variables is supported before we | ||
| //proceed any further | ||
| if !c.isConfigValid() { |
There was a problem hiding this comment.
We might either have to set ENABLE_IPv4 -> true by default or generate two manifests for v4 and v6 with ENABLE_IPv4=true in v4 manifest and ENABLE_IPv6=true in v6 manifest. Since if anyone builds based of master then aws-node will fail to start because both variables will be missing.
There was a problem hiding this comment.
We will include the new env vars in the default manifest.
There was a problem hiding this comment.
Agreed but this will fail nightly integration test :(
There was a problem hiding this comment.
So the default manifest will have v4 set to true?
There was a problem hiding this comment.
Yeah, v4 will be enabled by default.
What type of PR is this?
Feature
Which issue does this PR fix:
PR introduces IPv6 support for AWS VPC CNI.
What does this PR do / Why do we need it:
VPC CNI currently doesn't have the capability to support IPv6 based workloads/pods. PR introduces AWS VPC native IPv6 networking support for K8S Pods. It also provides the capability for Egress v4 access for IPv6 enabled pods.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Below scenarios are tests in IPv6 Mode.
Automation added to e2e:
PR includes UT support. Will send out a separate PR for e2e automation tests.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Upgrading a current IPv4 cluster to IPv6 mode will not be supported.
Does this change require updates to the CNI daemonset config files to work?:
Yes.
If this change does not work with a "kubectl patch" of the image tag, please explain why.
PR introduces support for two new environment variables -
ENABLE_IPv4andENABLE_IPv6. These env variables have to be configured based on the requirement.Does this PR introduce any user-facing change?:
Yes. User has to explicitly enable either IPv4 or IPv6 mode. Default VPC CNI manifests will enable IPv4 by default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.